Fix sol.fStar for NSGA2
#330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 84.22% 84.25% +0.03%
==========================================
Files 22 22
Lines 3340 3347 +7
==========================================
+ Hits 2813 2820 +7
Misses 527 527
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcomangano
previously approved these changes
Feb 25, 2023
marcomangano
previously approved these changes
Feb 27, 2023
sseraj
reviewed
Feb 27, 2023
pyoptsparse/pyNSGA2/pyNSGA2.py
Outdated
| @@ -188,6 +188,12 @@ def objconfunc(nreal, nobj, ncon, x, f, g): | |||
| for i in range(n): | |||
| xstar[i] = nsga2.doubleArray_getitem(x, i) | |||
|
|
|||
| if len_ff > 1: | |||
| for i in range(len_ff): | |||
| ff[i] = nsga2.doubleArray_getitem(f, i) | |||
There was a problem hiding this comment.
Can you add some comments to explain what's happening here? I don't understand why ff has to be overwritten.
There was a problem hiding this comment.
If I am not mistaken, ff is just initialized (as a 0-length array) in _assembleObjective. Before this fix, fStar was never updated with the value of the optimal objective f, returned from the actual optimizer called by nsga2.nsga2().
Moreover, f is a swig object so nsga2.doubleArray_getitem is necessary to convert it to a numpy array.
marcomangano
approved these changes
Feb 27, 2023
sseraj
approved these changes
Feb 27, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes the
sol.fStarvalue for NSGA2. Basically, the optimized f value was not being passed tocreateSolution.Expected time until merged
2 days
Type of change
Testing
An associated test is added which fails without the fix.
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable