Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved SNOPT time limit test to larger problem #334

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Moved SNOPT time limit test to larger problem #334

merged 2 commits into from
Mar 16, 2023

Conversation

sseraj
Copy link
Contributor

@sseraj sseraj commented Mar 15, 2023

Purpose

The HS071 case runs too quickly to reliably test the SNOPT time limit option. I moved the test to the TP109 instead and decreased the time.

Expected time until merged

ASAP because the buildbot is failing

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner March 15, 2023 14:01
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I had no problems when testing locally and I wanted to be consistent with other informs tests, but this is safer. Thanks!

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #334 (e8a8cd2) into main (aa83d79) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   84.25%   84.34%   +0.08%     
==========================================
  Files          22       22              
  Lines        3347     3347              
==========================================
+ Hits         2820     2823       +3     
+ Misses        527      524       -3     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eirikurj eirikurj merged commit 2eab4e1 into main Mar 16, 2023
@marcomangano marcomangano deleted the tp109-inform branch March 16, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants