-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some warnings #343
Remove some warnings #343
Conversation
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
===========================================
- Coverage 83.86% 72.43% -11.43%
===========================================
Files 22 22
Lines 3365 3352 -13
===========================================
- Hits 2822 2428 -394
- Misses 543 924 +381
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you bump the minor version? We are finally introducing some backward incompatibility so I think it's appropriate.
You will also have to merge this yourself as the issue with RTD is still unsolved
Purpose
Two types of warnings are removed:
mpi4py
, IMO this is a bit annoying for those that are not using the parallel featuresWe may want to make a release after this is merged, and clearly explain in the release notes that these deprecations are now removed.
Expected time until merged
Not urgent
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable