Skip to content

Commit

Permalink
Added a self-reference disable button in the extension popup
Browse files Browse the repository at this point in the history
  • Loading branch information
grubdragon committed Oct 14, 2020
1 parent 4b25c0a commit 9622e45
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
7 changes: 7 additions & 0 deletions html/popup.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ <h2 class="subtitle" id="pageSettings">Page settings</h2>
<span class="slider round"></span>
</label>

<p id="disableSelfReferences">Disable Survol on Self-referential links? (eg. github.com links on github.com)</p>

<label class="switch">
<input type="checkbox" id="disableSelfReferButton">
<span class="slider round"></span>
</label>

<h2 class="subtitle" id="generalSettings">General settings</h2>
<p id="allowMetadata">Allow meta-data preview ? (if disabled Survol will only preview youtube, twitter, wikipedia, ...)</p>

Expand Down
21 changes: 20 additions & 1 deletion js/popup/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ document.addEventListener('DOMContentLoaded', () => {
document.getElementById(word).innerText = chrome.i18n.getMessage(word);
});

chrome.storage.local.get(['disabledDomains', 'previewMetadata', 'darkThemeToggle'], function (res) {
chrome.storage.local.get(['disabledDomains', 'disabledSelfReferDomains', 'previewMetadata', 'darkThemeToggle'], function (res) {
let disabledDomains = res.disabledDomains ? res.disabledDomains : ['survol.me'];
let disabledSelfReferDomains = res.disabledSelfReferDomains ? res.disabledSelfReferDomains : ['survol.me'];
let previewMetadata = true;
let darkTheme = false;

Expand All @@ -35,6 +36,10 @@ document.addEventListener('DOMContentLoaded', () => {
document.getElementById('previewOnThisPage').checked = false;
}

if (disabledSelfReferDomains.includes(CURRENT_URL.toLowerCase())) {
document.getElementById('disableSelfReferButton').checked = true;
}

document.getElementById('previewMetadata').checked = previewMetadata;

document.getElementById('previewMetadata').addEventListener('click', () => {
Expand All @@ -61,6 +66,20 @@ document.addEventListener('DOMContentLoaded', () => {

chrome.storage.local.set({ disabledDomains: disabledDomains });
});

document.getElementById('disableSelfReferButton').addEventListener('click', () => {
// if the box gets unchecked i.e domain self-referencing disabled, and the domain is not already in the list add it
if (document.getElementById('disableSelfReferButton').checked && !disabledSelfReferDomains.includes(CURRENT_URL.toLowerCase())) {
disabledSelfReferDomains.push(CURRENT_URL.toLowerCase());
}

// If the box gets checked and the domain self-referencing is disabled, remove it from the disabled domains list
else if (!document.getElementById('disableSelfReferButton').checked && disabledSelfReferDomains.includes(CURRENT_URL.toLowerCase())) {
disabledSelfReferDomains = disabledSelfReferDomains.filter((domains) => { return domains != CURRENT_URL.toLowerCase(); });
}

chrome.storage.local.set({ disabledSelfReferDomains: disabledSelfReferDomains });
});
}
});
});
Expand Down

0 comments on commit 9622e45

Please sign in to comment.