Twitter integration : Embed medias #20 #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdolr
requested changes
Oct 12, 2019
There was a problem hiding this comment.
Hello, thanks for your contribution. I haven't tested it and I'm pretty sure it works but as an extension we're not allowed to insert HTML directly otherwise I would have done it already, I can't accept your pull request in this state.
You can't make the use of an id as you would get duplicate in a page with multiple tweets
The media link needs to be parsed from the HTML element and then you need to create a href using document.createElement('a') etc
Also there are conflicts with the current master branch you might want to get in sync with master before making another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves twitter tool-tip Twitter integration : Embed medias #20