Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVPersister includes commas in large values #14

Open
simonkelly1973 opened this issue May 2, 2019 · 1 comment
Open

CSVPersister includes commas in large values #14

simonkelly1973 opened this issue May 2, 2019 · 1 comment

Comments

@simonkelly1973
Copy link
Member

The Data Recorder app in OpenICE has several different "persisters" that are actually responsible for storing the data. Use of the CSVPersister is very common. It formats numbers using a "NumberFormat" and obtains a NumberFormat using NumberFormat.getNumberInstance() . By default, this number format uses "grouping" to create numbers that are better human readable. For instance, one thousand is presented as

1,000

However, this is obviously a problem in a CSV file, as the additional , characters in the output are treated as separators in the resulting output.

simonkelly1973 added a commit that referenced this issue May 2, 2019
@simonkelly1973
Copy link
Member Author

Commit 124aace fixes the issue by turning grouping off. I also included a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant