fix compilation with gcc6 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: linux/compiler-gcc6.h: No such file or directory Via macros the build will try to include a gcc version-specific header file, but this doesn't exist for gcc6, so use gcc5's header file for gcc6+. Tested with gcc6, didn't test with gcc7. Signed-off-by: Nicholas Sielicki <sielicki@yandex.com>
|
Hi Nicholas, Thanks for that! Ray K |
|
Hey Ray, Thank you for the quick merge! Yes, I am using a Galileo (Gen2) with Buildroot; their default toolchain now uses gcc6 and that's how/why I came across this issue. I've submitted a patch to buildroot to update the galileo defconfig to point at this commit, and you can find it here. |
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Sep 5, 2017
The kernel used so far for the galileo boards would not successfully build with GCC versions greater than 5. See: mdr78/Linux-x1000#2 Signed-off-by: Nicholas Sielicki <sielicki@yandex.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Oct 16, 2017
The kernel used so far for the galileo boards would not successfully build with GCC versions greater than 5. See: mdr78/Linux-x1000#2 Signed-off-by: Nicholas Sielicki <sielicki@yandex.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> (cherry picked from commit 62ec0af) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: linux/compiler-gcc6.h: No such file or directory
Via macros the build will try to include a gcc version-specific header
file, but this doesn't exist for gcc6, so use gcc5's header file for
gcc6+. Tested with gcc6, didn't test with gcc7.
Signed-off-by: Nicholas Sielicki sielicki@yandex.com