-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: several sitemap related issues #441
Conversation
…name to be set seperate from host, allow sitemap to be set using relative url
Hi folks! Thank you very much for contribution. It looks good to me. I am going to merge it. I am really sorry for the delayed review and response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please wait for a release in a couple of minutes, |
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change breaks when used with
Why is this breaking change not reflected in the version of this package update? |
Please see: #451 or open a new issue if appropriate |
Hi there, I have just started using the plugin and was confused by it's output differing from the docs I found in Gatsby's website. I expected them to live in example.com/sitemap.xml but they are instead located in example.com/sitemap/sitemap-index.xml. Can you please update the docs/README according to the latest changes? I know this is recent but it helps whoever finds themselves in the same situation as me! Thanks, |
I have fixed a couple small bugs. As noted in Support for v4 of gatsby-plugin-sitemap #438 the default sitemap name has changed to (
sitemap-index.xml
) though I am trying to revert the default path change from/sitemap
to/
in fix(gatsby-plugin-sitemap): Sitemap path bug gatsbyjs/gatsby#31184. If this change probably requires a major version bump as it would be breaking.Because of the above change in
gatsby-plugin-sitemap
I tried to set thesitemap
option on my site and it would not change from the default. Reading the code I realized there was a bug caused by theif
statement I've fixed this so the custom sitemap path can be set without declaring the host as well.I removed the dependency on nodes old
url
package to make this more compatible with modern node as well.I added logic to allow the custom sitemap to be a relative path and prefix the host.
I've put in logic to correctly handle Gatsby's
pathPrefix
feature.If you'd like me to split any of this up into smaller PRS or remove anything let me know. Thanks.
Fixes #438