Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests for opcode behavior #67

Open
mds1 opened this issue May 20, 2024 · 0 comments
Open

feat: add tests for opcode behavior #67

mds1 opened this issue May 20, 2024 · 0 comments
Labels
data update Add or modify data fetched for chains

Comments

@mds1
Copy link
Owner

mds1 commented May 20, 2024

For precompiles, we verify their existence with a test case that includes input calldata and an expected response. We should do something similar for opcodes. A few examples of why this is valuable:

  • create/create2 are supported on most chains, but some have different behavior (i.e. deploying to different addresses, like zksync).
  • On L2s, many opcodes behave differently by e.g. returning constants. For examples, see optimism docs and arbitrum docs

Ethereum mainnet should be considered the source of truth for what opcodes are expected to return. When there are deviations in a behavior, the UI should indicate this (for example, color the cell yellow on the /features page)

If feasible, consider reporting on the gas usage as well to facilitate gas comparisons.

cc @fvictorio

@mds1 mds1 added the data update Add or modify data fetched for chains label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data update Add or modify data fetched for chains
Projects
None yet
Development

No branches or pull requests

1 participant