Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Data Structures and Computations #29

Closed
mds1 opened this issue Aug 10, 2023 · 1 comment
Closed

feat(data): Data Structures and Computations #29

mds1 opened this issue Aug 10, 2023 · 1 comment

Comments

@mds1
Copy link
Owner

mds1 commented Aug 10, 2023

This issue is eligible for a bounty paid out in ETH on OP Mainnet. Read CONTRIBUTING.md to learn how to qualify.

Some chains like zkSync and other zkEVMs compute addresses differently and/or use hash functions that are not keccak256. As a result, CREATE and/or CREATE2 addresses can differ between chains.

Similarly, different block structures or state representations can result in different merkle proofs/roots for the same data.

Not yet sure the best name for this section, or the best way to represent the data. To illustrate why this is tricky: Imagine two chains both compute the address of a contract deployed via CREATE2 by keccak256( 0xff ++ address ++ salt ++ keccak256(init_code))[12:]. But one chain requires a custom solidity fork so the init code is different. The address computation is the same, but it's misleading to say "address calculation is the same" because in reality you won't get the same address due to the differing bytecode.

Maybe in this case we do things are the same, and we defer to a compilation/tooling section to explain the bytecode difference

@mds1
Copy link
Owner Author

mds1 commented May 20, 2024

Closing this issue as part of the move to automated data collection in #62. Things like differing address computation will be handled by #67

@mds1 mds1 closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant