This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
MCC-320723/bootstrap without chef #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This request is against master, as develop appears to have been neglected. When the next release of bootscript is performed, I will bring the develop branch back in line in the usual git-flow approach. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lengthy change. On the plus side, it includes changes for Windows machines, updated specs, and documentation on the Ansible support.
The trigger for Ansible support is just like that for Chef: include a certain variable in the call to the generate() method. For ansible, this is "tower_url", where an initial POST request is made. The body of this POST request is by default an empty JSON hash, but this can be changed by supplying a script to create the body to be sent.
This change also introduces the parameter "startup_failed_command". Previously, we had updated bootscript to mark nodes as unhealthy using the AWS CLI package. Perhaps this is not desired, or perhaps clients may want to do something else. Specifying a template under this key allows the caller to determine what, if anything, is done in the event the startup command fails.
@harryw @benton I am continuing to work on this change, but the end is close, so I'm opening this now to get some feedback.