Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multibyte encoding support #95

Merged
merged 56 commits into from
Nov 13, 2018

Conversation

glow-mdsol
Copy link
Member

Rollup of features from the other branch
Updating multibyte character support

handle deprecation of x.getchildren()
test adding alias to multiple elements
move httprettu to a test_require
Harmonised Doc Strings so Sphinx Autodoc works
Partition the Builder examples
Added docstrings to be able to autogen docs
run BLACK formatter over the module
Ran BLACK reformatting on the module (no code changes)
Reformatted documents (specifically around presentation of ..note sections)
rwslib/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@iansparks iansparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work from you (and other contributors?) One comment that may or may not be actionable at your discretion.

@glow-mdsol glow-mdsol mentioned this pull request Nov 13, 2018
Copy link
Collaborator

@iansparks iansparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed, thanks!

@glow-mdsol
Copy link
Member Author

@iansparks Thanks for your patience, the CI job is now complete and all changes have been backed out. You can merge at your pleasure

@iansparks iansparks merged commit 1a86bc0 into develop Nov 13, 2018
@glow-mdsol glow-mdsol deleted the feature/multibyte_encoding_support branch November 13, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants