Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for the great library! The PR improves and makes API more ergonomic and fix problem with performance.
Structure is:
Cabinet
->FolderEntries
->FolderReader
->FileEntries
->FileReader
.Changes
actions-rs
todtolnay/rust-toolchain
becauseactions-rs
is deprecatedFolderReader
for iterate overFileReader
FileReader
for reader file fromcab
Breaking changes
Cabinet::get_file_entry
Cabinet::read_file
If the idea is ok I can finish it.