Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain cython=0.29 #1801

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Constrain cython=0.29 #1801

merged 5 commits into from
Jul 19, 2023

Conversation

mattwthompson
Copy link
Member

Band-aid for #1800, which should be followed-up by a proper fix.

Version 3.0 (!) was released, but the current source code is only compatible with versions 0.29.x

Version 3.0 (!) was released, but the current source code is only compatible with versions 0.29.x
@jeremyleung521
Copy link
Contributor

jeremyleung521 commented Jul 18, 2023

I believe pip syntax requires a double equals sign == for version specification in pyproject.toml. test.yaml should be fine though since that's managed by conda.

@mattwthompson
Copy link
Member Author

So it was passing with 0.29.36 a few days ago:
https://github.com/mdtraj/mdtraj/actions/runs/5570950610/jobs/10175514121#step:3:272

It's now failing with ... 0.29.36: https://github.com/mdtraj/mdtraj/actions/runs/5588508191/jobs/10215400973#step:3:272

Something else must have changed - I haven't looked deeper

@mattwthompson
Copy link
Member Author

Oh, it's probably that I'm looking at the Cython in the conda environment, but a different one is used for the build process

@mattwthompson
Copy link
Member Author

Thanks for the help @jeremyleung521 - this looks good to me, what do you think?

@jeremyleung521
Copy link
Contributor

I suggest doing ==0.29.* or ~=0.29.36 just in case there is a newer 0.29.* bugfix somewhere down the line, but other than that, it looks good to me!

@mattwthompson
Copy link
Member Author

Oh, nice - conda doesn't support the tilde specifier so I didn't think of that

@mattwthompson mattwthompson merged commit 2ba38d8 into master Jul 19, 2023
6 checks passed
@mattwthompson mattwthompson deleted the mattwthompson-patch-1 branch July 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants