We need to add group.sort for VIT-2182. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,21 +76,47 @@ public static function sortToString($values) { | |||
| } | |||
|
|
|||
| public static function groupbyToString($values) { | |||
There was a problem hiding this comment.
This method is getting a bit long.
There was a problem hiding this comment.
I can't think of anything more groupbys would need, so it shouldn't get any longer
|
👍 |
| array('key' => 'group', 'value' => 'true') | ||
| ); | ||
| //set defaults | ||
| $groupbyItems = array('group.limit' => 1, |
There was a problem hiding this comment.
It looks like the new test is failing because of the integer 1 here and the string "1" in the test.
|
👍 |
BaseOfASE-Corp
added a commit
that referenced
this pull request
Dec 18, 2013
We need to add group.sort for VIT-2182.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the way groupbys work in Charizrd. Giving the models more control over the group fields