allowing real display_name select queries to be performed #47
Conversation
|
There are no legitimate cases where the value should be |
|
nope, it will either return a large query string or null |
allowing real display_name select queries to be performed
| $value = static::comboKeyValue($key, $value, $config); | ||
| if($value == null){ |
There was a problem hiding this comment.
if (is_null($value)) { ?
There was a problem hiding this comment.
is_null($value) is much slower than $value === null if you do it a billion times. Maybe we can add it to a loop to do it a billion times to justify $value === null over is_null() ? :D
There was a problem hiding this comment.
Good point. We should probably write this portion as a php plugin in C 😏
There was a problem hiding this comment.
Actually, I've never done one of those. Might be interesting to dive into the ugly flamewar-ridden underbelly of PHP.
...what am I saying?!
No description provided.