Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error: unexpected closing tag with style #139

Closed
cpboyd opened this issue Jan 24, 2020 · 1 comment
Closed

Parsing error: unexpected closing tag with style #139

cpboyd opened this issue Jan 24, 2020 · 1 comment
Labels
👀 no/external This makes more sense somewhere else

Comments

@cpboyd
Copy link

cpboyd commented Jan 24, 2020

Subject of the issue

Adding style={{}} seems to break parsing of closing tags.

error  Parsing error: Unexpected closing tag "Button". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags

Your environment

  • OS: macOS 10.15.2
  • Packages:
    "@typescript-eslint/eslint-plugin": "^2.17.0",
    "@typescript-eslint/parser": "^2.17.0",
    "eslint": "^6.8.0",
    "eslint-config-prettier": "^6.9.0",
    "eslint-config-react-app": "^5.1.0",
    "eslint-plugin-flowtype": "^4.6.0",
    "eslint-plugin-graphql": "^3.1.1",
    "eslint-plugin-import": "^2.20.0",
    "eslint-plugin-jsx-a11y": "^6.2.3",
    "eslint-plugin-mdx": "^1.6.5",
    "eslint-plugin-prettier": "^3.1.2",
    "eslint-plugin-react": "^7.18.0",
    "eslint-plugin-react-hooks": "^2.3.0",
  • Env: yarn 1.21.1

Steps to reproduce

---
title: Contact
---

import { Button } from '@rmwc/button';

# Contact

<Button
  raised
  style={{ margin: '8px' }}
>
  Message Me
</Button>

Expected behaviour

The parser should be able to style on a JSX tag.

Actual behaviour

The parser throws an error.

@cpboyd cpboyd added 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Jan 24, 2020
@cpboyd
Copy link
Author

cpboyd commented Jan 24, 2020

Seems to actually be an issue with prettier: prettier/prettier#7041

@cpboyd cpboyd closed this as completed Jan 24, 2020
@wooorm wooorm added 👀 no/external This makes more sense somewhere else and removed 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else
Development

No branches or pull requests

2 participants