Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list "eslint-plugin-react" as a peer dependency #229

Closed
kylemh opened this issue Aug 21, 2020 · 2 comments
Closed

list "eslint-plugin-react" as a peer dependency #229

kylemh opened this issue Aug 21, 2020 · 2 comments
Labels
🤷 no/invalid This cannot be acted upon

Comments

@kylemh
Copy link

kylemh commented Aug 21, 2020

Subject of the feature

When creating lint configs, many people will already install eslint-plugin-react. By listing the package as a devDependency and peerDependency, the consumer controls the version of the package.

Problem

The conflicting versions yield warnings during install and cause confusion as to which version of plugin is being adhered to during linting.

Expected behavior

What should happen? Please describe the desired behavior.

Alternatives

Always install the latest version and let people use resolutions if they need to pin it lower.

@kylemh kylemh added 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Aug 21, 2020
@JounQin
Copy link
Member

JounQin commented Sep 18, 2020

Actually we are using some metadata info from eslint-plugin-react (see https://github.com/mdx-js/eslint-mdx/blob/master/packages/eslint-plugin-mdx/src/rules/no-unescaped-entities.ts#L39), so I'm not a fan to mark it as peer dependency, but maybe we can just copy all the metadata info so that we can just drop eslint-plugin-react as dependency.

PR welcome.

@JounQin
Copy link
Member

JounQin commented Feb 20, 2021

close due to inactive, welcome to PR instead

@JounQin JounQin closed this as completed Feb 20, 2021
@wooorm wooorm added 🤷 no/invalid This cannot be acted upon and removed 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon
Development

No branches or pull requests

3 participants