Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last error does not disappear from MDX VS Code extension after fixed #400

Closed
4 tasks done
karlhorky opened this issue Feb 24, 2024 · 3 comments · Fixed by #401
Closed
4 tasks done

Last error does not disappear from MDX VS Code extension after fixed #400

karlhorky opened this issue Feb 24, 2024 · 3 comments · Fixed by #401
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Comments

@karlhorky
Copy link

karlhorky commented Feb 24, 2024 •
edited

Initial checklist

Affected packages and versions

MDX VS Code Extension v1.7.2

Link to runnable example

No response

Steps to reproduce

  1. Add an MDX document with the following (should show 2 errors with the MDX VS Code Extension v1.7.2): 
    - <component name>.module.scss filenames
- <componentx name>.module.scss filenames
  2. Resolve both errors by adding a backslash before the opening <
  3. Observe that the last resolved error remains 💥
  4. Confirm that it is not actually an error by reloading VS Code
Kapture.2024-02-24.at.15.10.56.mp4

Expected behavior

After the last error is resolved, there should no longer be any errors visible anywhere

Actual behavior

After the last error is resolved, the last error remains

Runtime

Node v20

Package manager

pnpm

OS

macOS

Build and bundle tools

No response

cc @remcohaszing
@karlhorky karlhorky changed the title Last error does not disappear from MDX after fixed Last error does not disappear from MDX VS Code extension after fixed Feb 24, 2024
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 24, 2024
remcohaszing added a commit to volarjs/volar.js that referenced this issue Feb 25, 2024
@remcohaszing
fix(language-service): fix caching of semantic diagnostics
74b3600 
Refs mdx-js/mdx-analyzer#400
@remcohaszing remcohaszing mentioned this issue Feb 25, 2024
Merged
johnsoncodehk pushed a commit to volarjs/volar.js that referenced this issue Feb 26, 2024
@remcohaszing
fix(language-service): fix caching of semantic diagnostics (#141)
2de64b2 
Refs mdx-js/mdx-analyzer#400
remcohaszing added a commit that referenced this issue Feb 26, 2024
@remcohaszing
Update to Volar 2.1
7c34381 
Closes #400
remcohaszing added a commit that referenced this issue Feb 26, 2024
@remcohaszing
Update to Volar 2.1
d17e6ed 
Closes #400
@remcohaszing remcohaszing mentioned this issue Feb 26, 2024
Merged
5 tasks
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on labels Feb 26, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 26, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added the 👶 semver/patch This is a backwards-compatible fix label Feb 26, 2024
remcohaszing added a commit that referenced this issue Feb 26, 2024
@remcohaszing
Update to Volar 2.1
8c35ef3 
Closes #400
remcohaszing added a commit that referenced this issue Feb 26, 2024
@remcohaszing
Update to Volar 2.1 (#401)
48be843 
Closes #400
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Feb 26, 2024
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Feb 26, 2024
@karlhorky
Copy link
Author

I can confirm that the new version has resolved the issue 🎉

Thanks @remcohaszing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Volar 2.1 mdx-js/mdx-analyzer
2 participants
@remcohaszing @karlhorky