Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For some reason vscode-markdown-languageservice is enabled #424

Closed
4 tasks done
wooorm opened this issue Apr 2, 2024 · 3 comments · Fixed by #429
Closed
4 tasks done

For some reason vscode-markdown-languageservice is enabled #424

wooorm opened this issue Apr 2, 2024 · 3 comments · Fixed by #429
Labels
📦 area/deps This affects dependencies 🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Comments

@wooorm
Copy link
Member

wooorm commented Apr 2, 2024

Initial checklist

Affected packages and versions

current

Link to runnable example

No response

Steps to reproduce

  • clone MDX
  • use vscode-mdx
  • open an MDX file (such as extending-mdx.mdx)
  • observe that vscode-markdown-languageservice (presumably) is emitting diagnostics about broken links
Screenshot 2024-04-02 at 1 02 44 PM

Expected behavior

MDX is not markdown, so a regular tool that only works on markdown, should not run.
We could have remark run on MDX files, but I‘d want to discuss that in a separate issue.

Actual behavior

markdown tools that are unaware of MDX run

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Apr 2, 2024
@remcohaszing
Copy link
Member

vscode-markdown-languageservice works on the generated virtual markdown code. It provides not just diagnostics, but also link references, completions, document outline, etc.

But yes, I did notice some diagnostics that shouldn’t be there.

@remcohaszing remcohaszing added 🐛 type/bug This is a problem 📦 area/deps This affects dependencies 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 🙆 yes/confirmed This is confirmed and ready to be worked on labels Apr 2, 2024
@github-actions github-actions bot added 👍 phase/yes Post is accepted and can be worked on and removed 🤞 phase/open Post is being triaged manually labels Apr 2, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
remcohaszing added a commit that referenced this issue Apr 9, 2024
@remcohaszing
Disable markdown based linting by default
cae4c8a 
VSCode does this for markdown files too. Some validation results are not
wanted. Some are even false positives.

Closes #424
@remcohaszing remcohaszing mentioned this issue Apr 9, 2024
Merged
5 tasks
remcohaszing added a commit that referenced this issue Apr 12, 2024
@remcohaszing
Disable markdown based linting by default (#429)
004b802 
VSCode does this for markdown files too. Some validation results are not
wanted. Some are even false positives.

Closes #424
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Apr 12, 2024
@github-actions github-actions bot removed 👍 phase/yes Post is accepted and can be worked on 🙆 yes/confirmed This is confirmed and ready to be worked on labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 area/deps This affects dependencies 🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable markdown based linting by default mdx-js/mdx-analyzer
2 participants
@remcohaszing @wooorm