ci: add publish workflow for releasing on CI automatically #207

JounQin · 2022-07-06T08:34:29Z

close #177
close #188

@asbjornu Can you please help to review the publishing workflow?

@wooorm An OPEN_VSX_TOKEN and a VSCE_TOKEN secrets are required.

github-actions · 2022-07-06T08:34:53Z

📊 Package size report `13%↑`

File	Before	After
`.changeset/config.json`	—	`312 B`
`.changeset/loud-weeks-laugh.md`	—	`88 B`
`.changeset/README.md`	—	`510 B`
`.changeset/selfish-birds-lick.md`	—	`69 B`
`.github/workflows/publish.yml`	—	`1.2 kB`
`.github/workflows/release.yml`	—	`323 B`
`.github/workflows/version.yml`	—	`1.0 kB`
`.vscodeignore`	`101 B`	^2%↑`103 B`
`package.json`	`4.5 kB`	^1%↑`4.5 kB`
`README.md`	`6.8 kB`	^-0.47%↓`6.8 kB`
`release.sh`	`214 B`	—
Total _{(Includes all files)}	`24.6 kB`	^13%↑`27.9 kB`
Tarball size	`10.9 kB`	^10%↑`12.0 kB`

Unchanged files

File	Size
`.commitlintrc`	`35 B`
`.editorconfig`	`161 B`
`.eslintignore`	`22 B`
`.eslintrc`	`191 B`
`.github/FUNDING.yml`	`234 B`
`.github/workflows/ci.yml`	`551 B`
`.github/workflows/pkg-size.yml`	`489 B`
`.lintstagedrc.js`	`46 B`
`.prettierrc`	`24 B`
`.renovaterc`	`35 B`
`.simple-git-hooks.js`	`51 B`
`.vscode/launch.json`	`540 B`
`.yarnrc`	`20 B`
`assets/mdx.png`	`3.3 kB`
`CHANGELOG.md`	`2.5 kB`
`language-configuration.jsonc`	`1.1 kB`
`LICENSE`	`1.1 kB`
`patches/eslint-mdx+2.0.1.patch`	`796 B`
`syntaxes/mdx.tmLanguage.json`	`1.3 kB`
`test/component.js`	`54 B`
`test/fixture.mdx`	`423 B`

_{🤖 This report was automatically generated by pkg-size-action}

silvenon

Other stuff looks 👌

.github/workflows/publish.yml

wooorm

I don’t see anything weird, but I have no real experience with publishing to vscode.

I have completely forgotten how to get those tokens. Any ideas? Must I add them before this can be merged?

JounQin · 2022-07-09T02:05:39Z

I have completely forgotten how to get those tokens. Any ideas? Must I add them before this can be merged?

Right. For vsce, it should be added at https://dev.azure.com/{account}/_usersSettings/tokens, for open-vsx, I'm also not so familiar too. Maybe @asbjornu can offer some help.

JounQin · 2022-07-09T02:06:58Z

@wooorm

And also, I'd like to enable https://github.com/changesets/changesets for auto releasing with better CHANGELOG, just sent an installation request, can you help to accept?

JounQin · 2022-07-09T02:15:13Z

@wooorm

EclipseFdn/open-vsx.org#423

It seems you've claimed already for open-vsx.

And the next questions are:

can you give me the open-vsx namespace permission?
can you add me into the azure organization with correct permission?
can you enable my permission to manage the Actions secrets?

wooorm · 2022-07-10T15:48:00Z

I approved the two applications you requested on the two repos you maintain here

can you give me the open-vsx namespace permission?

I added you as a contributor on open-vcx. Which permissions do you mean?

can you add me into the azure organization with correct permission?

You already are a contributor in that organization. What else do you need.

can you enable my permission to manage the Actions secrets?

As discussed before, I don’t think that it's safe for all members to access all information in the unified organizations that has many different contributors. We already have a releasers team in the MDX organization that has access to that, and we have the core team that has access to that. I think we should have a small number of people that have access to vulnerable information.

There is already a VSCE_TOKEN secret here from March 2021 btw.

wooorm · 2022-07-10T15:49:05Z

For vsce, it should be added at https://dev.azure.com/{account}/_usersSettings/tokens

I believe that all the docs on vscode extensions are out of date. These URLs and guides don’t work for me.

JounQin · 2022-07-10T16:20:15Z

@wooorm Great to know! Then the last thing left should be OPEN_VSX_TOKEN which should have publish permission?

JounQin · 2022-07-10T16:37:02Z

I added you as a contributor on open-vcx. Which permissions do you mean?

Besides, I see no namespace available to me on open-vsx.org still.

wooorm · 2022-07-10T17:32:23Z

There is already a VSCE_TOKEN secret here from March 2021 btw.

Did you add this a year ago? Perhaps its old and not for unifiedjs?

Then the last thing left should be OPEN_VSX_TOKEN

I added a OPEN_VSX_TOKEN token.

Besides, I see no namespace available to me on open-vsx.org still.

JounQin · 2022-07-10T22:39:09Z

Did you add this a year ago? Perhaps its old and not for unifiedjs?

I have no permission to add secret.

The token will be expired in one year, that's a question.

JounQin · 2022-07-10T23:37:52Z

@wooorm

https://dev.azure.com/{account}/_usersSettings/tokens

This link is not outdated and works to me, maybe you have a different username for Microsoft account?

JounQin · 2022-07-11T00:13:42Z

remarkjs/vscode-remark#40 (comment)

Previous context that may help. @wooorm

cc @asbjornu Do you have a latest VSCE_TOKEN.

changeset-bot · 2022-07-11T00:43:39Z

🦋 Changeset detected

Latest commit: 338c662

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vscode-mdx	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wooorm · 2022-07-11T08:51:23Z

maybe you have a different username for Microsoft account?

I indeed have different accounts. None of those accounts can access that page.
My account connected to GitHub can access pages outside of dev.azure.com.

The token will be expired in one year, that's a question.

If I added it a year ago, I don’t think so. I am guessing it will work.

JounQin · 2022-07-11T09:16:30Z

If I added it a year ago, I don’t think so. I am guessing it will work.

OK then, let's merge and give it a try!

JounQin · 2022-07-11T09:35:58Z

https://github.com/mdx-js/vscode-mdx/runs/7279615594?check_suite_focus=true#step:6:20

@wooorm Please help to see, maybe a new token is required for a new extension.

JounQin · 2022-07-11T09:39:54Z

It's already available at https://open-vsx.org/extension/unifiedjs/vscode-mdx, but not https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx

wooorm · 2022-07-11T09:43:16Z

microsoft/vsmarketplace#354 (comment).

Ideas:

Looks like they’ll allow just the extendionId (vscode-mdx) in the future? It appears the marketplace rejects certain "reserved" keywords as extension name microsoft/vsmarketplace#354 (comment)
Perhaps we can find a workaround where we can move your extension to the unifiedjs publisher “scope”?

JounQin · 2022-07-11T10:24:13Z

Perhaps we can find a workaround where we can move your extension to the unifiedjs publisher “scope”?

I hope we can do that also, but found no solution yet.

asbjornu · 2022-07-14T20:48:21Z

What's the current status here and how may I be of assistance? :)

JounQin · 2022-07-14T22:35:37Z

What's the current status here and how may I be of assistance? :)

@asbjornu

We want to transfer my extension to unifiedjs scope, but I didn't find any solution yet, do you have any experience?

Or is that possible to contact MS service? (I'm not a native English speaker, if you could such help, that would be great!)

remcohaszing · 2022-07-15T17:51:23Z

.github/workflows/publish.yml

+        run: yarn --frozen-lockfile
+
+      - name: ovsx publish
+        uses: HaaLeo/publish-vscode-extension@v1


Are there any benefits to use this action instead of the official vsce CLI?

Also: nice that this extension is also published to the Open VSX registry.

It keeps usage consistency between vsce and open-vsx, I supposed?

asbjornu · 2022-07-18T21:31:19Z

@JounQin, have a look at the discussion in remarkjs/vscode-remark#28. I don't remember exactly how we did it, but I think by reading the comments you should figure out what we did to move vscode-remark from @mrmlnc to remarkjs.

wooorm · 2022-07-19T07:32:55Z

@asbjornu Back then we used the same “top-level” identifier: vscode-remark. Due to this it exists under mrmlnc and unifiedjs. This was allowed, but it is no longer allowed: #207 (comment).

asbjornu · 2022-07-19T19:49:34Z

Ok, then I have no idea, sorry. 🤷🏼

remcohaszing · 2022-07-20T12:55:55Z

Perhaps we can try uploading the extension to the VSCode markerplace manually. Maybe some special setup is needed for the initial upload.

Alternatively we could rename the extension from vscode-mdx to mdx. There are some discussion for this as well in remarkjs/vscode-remark#66. The main reason to not do it was because it would be a churn, but given the current situation it might actually be convenient for this extension.

wooorm · 2022-07-20T16:44:44Z

I’m quite liking releasing it as mdx!

JounQin · 2022-08-05T15:15:45Z

https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx v1.0.1 is finally been released!

Thanks, @madhurivadaligithub, for help at microsoft/vsmarketplace#440

For question: Is that possible to transfer an extension to another publisher org?

The answer is YES!

ci: add publish workflow for releasing on CI automatically

c4ee087

JounQin added the release label Jul 6, 2022

JounQin requested review from wooorm and a team July 6, 2022 08:34

JounQin self-assigned this Jul 6, 2022

This was referenced Jul 6, 2022

Republish this as unifiedjs #188

Closed

[POC] Start support typescript #196

Closed

silvenon reviewed Jul 6, 2022

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

wooorm approved these changes Jul 8, 2022

View reviewed changes

ci: release via changeset, publish on release published

109d80f

JounQin force-pushed the ci/publish branch from 6c8febc to 02c5f17 Compare July 10, 2022 02:26

ci: workflow: version -> release -> publish

3673f0a

JounQin force-pushed the ci/publish branch from 02c5f17 to 3673f0a Compare July 10, 2022 02:29

chore: add patches and test into .vscodeignore

965f860

Update README.md

ff99601

JounQin added 2 commits July 11, 2022 08:44

Create loud-weeks-laugh.md

060977d

Create selfish-birds-lick.md

338c662

JounQin merged commit 1181523 into master Jul 11, 2022

JounQin deleted the ci/publish branch July 11, 2022 09:16

github-actions bot mentioned this pull request Jul 11, 2022

chore: release vscode-mdx v1.0.0 #208

Merged

remcohaszing reviewed Jul 15, 2022

View reviewed changes

remcohaszing mentioned this pull request Jul 15, 2022

Add Release Drafter remarkjs/vscode-remark#45

Closed

JounQin mentioned this pull request Jul 17, 2022

Add invoice for @JounQin unifiedjs/collective#56

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add publish workflow for releasing on CI automatically #207

ci: add publish workflow for releasing on CI automatically #207

JounQin commented Jul 6, 2022 •

edited

Loading

github-actions bot commented Jul 6, 2022 •

edited

Loading

silvenon left a comment

wooorm left a comment •

edited

Loading

JounQin commented Jul 9, 2022

JounQin commented Jul 9, 2022

JounQin commented Jul 9, 2022 •

edited

Loading

wooorm commented Jul 10, 2022

wooorm commented Jul 10, 2022

JounQin commented Jul 10, 2022 •

edited

Loading

JounQin commented Jul 10, 2022

wooorm commented Jul 10, 2022

JounQin commented Jul 10, 2022

JounQin commented Jul 10, 2022

JounQin commented Jul 11, 2022 •

edited

Loading

changeset-bot bot commented Jul 11, 2022 •

edited

Loading

wooorm commented Jul 11, 2022

JounQin commented Jul 11, 2022

JounQin commented Jul 11, 2022

JounQin commented Jul 11, 2022

wooorm commented Jul 11, 2022 •

edited

Loading

JounQin commented Jul 11, 2022

asbjornu commented Jul 14, 2022

JounQin commented Jul 14, 2022

remcohaszing Jul 15, 2022

JounQin Jul 15, 2022

asbjornu commented Jul 18, 2022 •

edited

Loading

wooorm commented Jul 19, 2022

asbjornu commented Jul 19, 2022

remcohaszing commented Jul 20, 2022 •

edited

Loading

wooorm commented Jul 20, 2022 •

edited

Loading

JounQin commented Aug 5, 2022 •

edited

Loading

ci: add publish workflow for releasing on CI automatically #207

ci: add publish workflow for releasing on CI automatically #207

Conversation

JounQin commented Jul 6, 2022 • edited Loading

github-actions bot commented Jul 6, 2022 • edited Loading

📊 Package size report 13%↑

silvenon left a comment

Choose a reason for hiding this comment

wooorm left a comment • edited Loading

Choose a reason for hiding this comment

JounQin commented Jul 9, 2022

JounQin commented Jul 9, 2022

JounQin commented Jul 9, 2022 • edited Loading

wooorm commented Jul 10, 2022

wooorm commented Jul 10, 2022

JounQin commented Jul 10, 2022 • edited Loading

JounQin commented Jul 10, 2022

wooorm commented Jul 10, 2022

JounQin commented Jul 10, 2022

JounQin commented Jul 10, 2022

JounQin commented Jul 11, 2022 • edited Loading

changeset-bot bot commented Jul 11, 2022 • edited Loading

🦋 Changeset detected

wooorm commented Jul 11, 2022

JounQin commented Jul 11, 2022

JounQin commented Jul 11, 2022

JounQin commented Jul 11, 2022

wooorm commented Jul 11, 2022 • edited Loading

JounQin commented Jul 11, 2022

asbjornu commented Jul 14, 2022

JounQin commented Jul 14, 2022

remcohaszing Jul 15, 2022

Choose a reason for hiding this comment

JounQin Jul 15, 2022

Choose a reason for hiding this comment

asbjornu commented Jul 18, 2022 • edited Loading

wooorm commented Jul 19, 2022

asbjornu commented Jul 19, 2022

remcohaszing commented Jul 20, 2022 • edited Loading

wooorm commented Jul 20, 2022 • edited Loading

JounQin commented Aug 5, 2022 • edited Loading

JounQin commented Jul 6, 2022 •

edited

Loading

github-actions bot commented Jul 6, 2022 •

edited

Loading

📊 Package size report `13%↑`

wooorm left a comment •

edited

Loading

JounQin commented Jul 9, 2022 •

edited

Loading

JounQin commented Jul 10, 2022 •

edited

Loading

JounQin commented Jul 11, 2022 •

edited

Loading

changeset-bot bot commented Jul 11, 2022 •

edited

Loading

wooorm commented Jul 11, 2022 •

edited

Loading

asbjornu commented Jul 18, 2022 •

edited

Loading

remcohaszing commented Jul 20, 2022 •

edited

Loading

wooorm commented Jul 20, 2022 •

edited

Loading

JounQin commented Aug 5, 2022 •

edited

Loading