Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of MDXContent in case of syntax error #375

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This means that if the component is used in another file, the return type of MDXContent is inferred as JSX.Element, not void.

This means that if the component is used in another file, the return
type of MDXContent is inferred as JSX.Element, not void.
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Dec 18, 2023
Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: be72b7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@mdx-js/language-service Patch
@mdx-js/language-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Hi! This is accepted and can go somewhere!

Team: please review this PR and use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this.

@remcohaszing remcohaszing marked this pull request as ready for review December 18, 2023 14:45
@remcohaszing remcohaszing merged commit d808f9c into main Dec 18, 2023
13 checks passed
@remcohaszing remcohaszing deleted the handle-error-mdx-content-return-type branch December 18, 2023 14:45
Copy link
Contributor

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

None yet

1 participant