Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplication when organizing imports #391

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

remcohaszing
Copy link
Member

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Organizing imports sometimes duplicates them. This fixes that by including a trailing newline right after the ESM nodes in the virtual code ranges.

Initial checklist

Organizing imports sometimes duplicates them. This fixes that by
including a trailing newline right after the ESM nodes in the virtual
code ranges.
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Feb 2, 2024
Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: 3654f2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@mdx-js/language-service Patch
@mdx-js/language-server Patch
vscode-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This comment has been minimized.

@remcohaszing remcohaszing merged commit 2b29d7a into main Feb 2, 2024
13 checks passed
@remcohaszing remcohaszing deleted the fix-import-sort branch February 2, 2024 13:22

This comment has been minimized.

@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Feb 2, 2024
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Feb 2, 2024
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

None yet

1 participant