Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update math-blocks.mdx with Gastby implementation. #1241

Merged
merged 3 commits into from Nov 7, 2020
Merged

Update math-blocks.mdx with Gastby implementation. #1241

merged 3 commits into from Nov 7, 2020

Conversation

jackpeplinski
Copy link

@vercel vercel bot temporarily deployed to Preview August 29, 2020 18:28 Inactive
@vercel
Copy link

vercel bot commented Aug 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/9ojiaknr6
✅ Preview: https://mdx-git-fork-jackpeplinski-patch-1.mdx.vercel.app

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackpeplinski!
I've added some comments below.
I'm also not sure if this is where this documentation should live, both gatsby-plugin-mdx and gatsby-remark-katex are part of the Gatsby project rather than MDX, it may be worth considering documenting this on the Gatsby side. Thoughts @mdx-js/maintainers?

docs/guides/math-blocks.mdx Outdated Show resolved Hide resolved
docs/guides/math-blocks.mdx Outdated Show resolved Hide resolved
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
@vercel vercel bot temporarily deployed to Preview August 30, 2020 02:28 Inactive
@vercel vercel bot temporarily deployed to Preview August 30, 2020 02:34 Inactive
@jackpeplinski
Copy link
Author

@ChristianMurphy That's a good point.

I only thought to include this edit because there was a NextJS implementation example.

@johno
Copy link
Member

johno commented Nov 7, 2020

Yeah I think we can merge so it's colocated with the other related documentation, but maybe we can also link out to where it lives in the Gatsby docs, too?

@johno johno merged commit f2074a7 into mdx-js:master Nov 7, 2020
@johno
Copy link
Member

johno commented Nov 7, 2020

Also, thank you @jackpeplinski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants