Add jsxFrag pragma, use fragment for shortcode warning
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooorm
added
🦋 type/enhancement
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/kuv4bjz5w [Deployment for d7a1473 failed] |
ChristianMurphy
approved these changes
Dec 19, 2020
wooorm
force-pushed
the
missing-shortcode-fragment
branch
from
027a1dd
to
80cbc9a
Compare
johno
approved these changes
Dec 20, 2020
This adds a `/* @jsxFrag mdx.Fragment */` next to the existing `/* @jsx mdx */` pragma. From MDX runtimes, this exports as `mdx.Fragment` either `React.Fragment` or `Preact.Fragment`. Vue 2 does not support fragments, but as JSX and hence MDX is already specific to React or Vue, well: folks shouldn’t use fragments in MDX files targeting Vue. As we have fragments, we can also use that to pass children through missing components: `<>{props.children}</>`. This fixes runtimes where HTML is not available, such as React Native. But, as Vue doesn’t like that, there’s a hidden flag to still use the original behavior: `<div {...props} />`. Still, there remains a difference in frameworks: Vue does not put `children` in `props`, so `{...props}` has never passed children along in Vue. Closes GH-972. Closes GH-990. Closes GH-1014.
wooorm
force-pushed
the
missing-shortcode-fragment
branch
from
80cbc9a
to
d7a1473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
/* @jsxFrag mdx.Fragment */next to the existing/* @jsx mdx */pragma.From MDX runtimes, this exports as
mdx.FragmenteitherReact.Fragmentor
Preact.Fragment.Vue 2 does not support fragments, but as JSX and hence MDX is already
specific to React or Vue, well: folks shouldn’t use fragments in MDX
files targeting Vue.
As we have fragments, we can also use that to pass children through
missing components:
<>{props.children}</>.This fixes runtimes where HTML is not available, such as React Native.
But, as Vue doesn’t like that, there’s a hidden flag to still use
the original behavior:
<div {...props} />.Still, there remains a difference in frameworks: Vue does not put
childreninprops, so{...props}has never passed children alongin Vue.
Closes GH-972.
Closes GH-990.
Closes GH-1014.