Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for named export default from #1395

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Add support for named export default from #1395

merged 1 commit into from
Dec 20, 2020

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Dec 19, 2020

Previously, only export default const a = 1 was supported.
This adds support for export {default} from "a" and
export {a as default} from "b" declarations.

Closes GH-961.

@wooorm
Add support for named export default from
ab9a574 
Previously, only `export default const a = 1` was supported.
This adds support for `export {default} from "a"` and
`export {a as default} from "b"` declarations.

Closes GH-961.
@wooorm wooorm added 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on 🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change labels Dec 19, 2020
@vercel
Copy link

vercel bot commented Dec 19, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/jeatmvcem
✅ Preview: Failed

johno
johno approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@wooorm wooorm merged commit 9d5d000 into main Dec 20, 2020
@wooorm wooorm deleted the export-default-from branch December 20, 2020 09:14
@wooorm wooorm added 💪 phase/solved Post is done and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make export { default } from "…" work
3 participants
@wooorm @johno @ChristianMurphy