Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme, website #1735

Merged
merged 8 commits into from Oct 12, 2021
Merged

Update readme, website #1735

merged 8 commits into from Oct 12, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Oct 12, 2021

Another pass

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/6cXfEkG6zpmwjCtogwdNPsKFwYXZ
✅ Preview: https://mdx-git-pass-3-mdx.vercel.app

@wooorm wooorm merged commit 003665f into main Oct 12, 2021
@wooorm wooorm deleted the pass-3 branch October 12, 2021 17:48
@@ -244,7 +243,7 @@ pre code,
.hljs,
.frame-body,
.frame-tab-item-selected {
background-color: #fafafa; /* Color from one-light */
background-color: #fafafa !important; /* Color from one-light */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to increase specificity rather than applying important?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They overwrite files that are loaded later (lazy loaded).
Previously I worked around it by loading them first. But as they don’t need to be blocking, and lighthouse warns, 🤷‍♂️

@@ -879,7 +878,7 @@ button.success {
.frame-body,
.frame-tab-item-selected,
.frame-tab-item-dark.frame-tab-item-selected {
background-color: var(--gray-7);
background-color: var(--gray-7) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to increase specificity rather than applying important?

@@ -1088,7 +1087,7 @@ button.success {
/* Fix a11y. */
.hljs-built_in,
.hljs-symbol {
color: hsl(24deg 92% 40%);
color: hsl(24deg 92% 40%) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to increase specificity rather than applying important?

@@ -1103,11 +1102,11 @@ button.success {
}

.hljs-section {
color: hsl(216deg 84% 62%);
color: #488bef !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to increase specificity rather than applying important?

}

.hljs-built_in,
.hljs-symbol {
color: #ffa657;
color: #ffa657 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to increase specificity rather than applying important?

@ChristianMurphy ChristianMurphy added 📚 area/docs This affects documentation 🕸 area/website This affects the website labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 🕸 area/website This affects the website
Development

Successfully merging this pull request may close these issues.

None yet

2 participants