-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syntax-highlighting.server.mdx #1894
Conversation
add a note about the necessity of ESM for rehype.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/4VE1p722yRZX8BVm14vqY4GUcUZY |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally applies to all remark and rehype plugins. (Since unifiedjs/unified#121)
Not just rehype-highlight
, it may make sense to add the note to https://mdxjs.com/docs/getting-started/#nextjs
This is the first time I've used the "edit" on github feature. I thought it would be a low overhead way to propose a change - turns out though that github just forked your repo and added a branch in my account! Anyway, I added another commit to my proposal. |
I don’t think this is the place to explain how to use ESM for MDX with each tool, or that all plugins are ESM. It would become a giant section, which is very similar to the existing Getting started or Extending MDX articles. How about instead using ESM for the example in Getting started: https://mdxjs.com/docs/getting-started/#nextjs |
Then please do it yourself. I had an afterthought on this: the next.js starter, as of today, doesn't create a |
add a note about the necessity of ESM for rehype.