Property adjustments for "style", "aria-*" and "data-*" #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
Some plugins like rehype-katex add properties like "style" and "aria-hidden", which need to be adjusted for JSX. This commit introduces the following changes: - style strings now turn into camelized objects - aria-* and data-* properties now have keys in param-case Fixes #145.
|
Seems to have errors in SSR? |
|
@linonetwo could you be more specific? |
|
I set the testing environment for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins like rehype-katex add properties like
styleandaria-hidden, which need to be adjusted for JSX. This commit introduces the following changes:stylestrings now turn into camelized objectsaria-*anddata-*properties now have keys in param-caseAfter these changes I can run the example in #145, but I have only tried with React, not Preact. However, the issue that this solves isn't the from the OP, but rather #145 (comment).