Update Lerna and implement Yarn workspaces #289
Conversation
|
This pull request is automatically deployed with Now. |
| @@ -5,5 +5,6 @@ node_js: | |||
| git: | |||
| depth: 5 | |||
| cache: | |||
| yarn: true | |||
There was a problem hiding this comment.
I'm not sure if this is necessary, i.e. if it happens by default.
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "lerna": "2.5.1", | |||
There was a problem hiding this comment.
Lerna v3 doesn't have this field.
| "docs": "x0 docs", | ||
| "docs:build": "x0 build docs", | ||
| "docs:deploy": "npm run docs:build && now dist --public && now alias", | ||
| "test": "lerna run test", | ||
| "format": "prettier --no-semi --single-quote --write '{examples,packages}/**/*.js'", | ||
| "prepare": "lerna bootstrap && lerna link --force-local" |
There was a problem hiding this comment.
I removed the prepare script because lerna bootstrap in Lerna v3 triggers that script, so it causes an endless loop. It would be ideal if we could keep this, because then lerna bootstrap would happen automatically and contributors and Travis CI wouldn't have to know about it, so I'm open to ideas.
| @@ -22,7 +22,7 @@ | |||
| "unist-util-visit": "^1.3.0" | |||
| }, | |||
| "devDependencies": { | |||
| "jest": "^22.4.3", | |||
| "jest": "^23.6.0", | |||
There was a problem hiding this comment.
Tests were failing for mdxast, updating Jest fixed it.
silvenon
force-pushed
the
workspaces
branch
2 times, most recently
from
48497b9
to
47ed6be
Compare
|
I'm having a hard time figuring out why tests are failing. I'll investigate tomorrow. |
silvenon
force-pushed
the
workspaces
branch
2 times, most recently
from
c5c75ca
to
f2d5a1f
Compare
| before_script: | ||
| # https://github.com/lerna/lerna/issues/1457#issuecomment-399678173 | ||
| - yarn lerna exec yarn install | ||
| - yarn lerna link --force-local |
There was a problem hiding this comment.
Maybe it's a Lerna + Linux issue, but lerna bootstrap seems to work only partially on Travis, while lerna exec yarn install works entirely. lerna/lerna#1457 (comment)
I'm adding this workaround for now, but I'll also report this issue to Lerna to see if they can figure it out.
| @@ -51,4 +51,4 @@ const testFixture = (fixture, options = {}) => { | |||
|
|
|||
| test('it loads markdown and returns a component', async () => { | |||
| await testFixture('fixture.md') | |||
| }) | |||
| }, 10000) | |||
There was a problem hiding this comment.
Previously Node v8 tests were failing, but now Node v10 were failing too, or instead. This seems to fix it.
silvenon
force-pushed
the
workspaces
branch
3 times, most recently
from
a80cbf3
to
9f64077
Compare
|
I was trying to remove that Anyway, enough tinkering, tests are passing so it's ready. |
I updated the docs and Travis to prefer Yarn because we ship
yarn.lockand we have workspaces. But everything works with npm too.I also increased the timeout for the loader test. I'll proceed by adding inline comments.
Closes #268.