Add failing tests for custom delete component #802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-fork-markmichon-delete-tests.mdx.now.sh |
Luiginator
reviewed
Oct 22, 2019
| @@ -16,7 +16,9 @@ const IMPORT_FIXTURE = fs.readFileSync( | |||
| const components = { | |||
| h1: ({children}) => | |||
| React.createElement('h1', {style: {color: 'tomato'}}, children), | |||
| Button: () => React.createElement('button', {}, 'Hello, button!') | |||
| Button: () => React.createElement('button', {}, 'Hello, button!'), | |||
| delete: ({children}) => | |||
There was a problem hiding this comment.
'del: ({children}) =>' to make this test work.
| it('Should render delete as del', () => { | ||
| const result = renderToString( | ||
| <MDXProvider components={{delete: CustomDelete}}> | ||
| <Fixture /> |
There was a problem hiding this comment.
This test fails because the Fixture does not contain a tag.
|
Thanks for opening up this PR! I'm going to go ahead and close this since there's now a test that verifies the proper behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included are failing tests for #801