Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release vscode-mdx #257

Merged
merged 1 commit into from
Jan 13, 2023
Merged

chore: release vscode-mdx #257

merged 1 commit into from
Jan 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 29, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

vscode-mdx@1.1.0

Minor Changes

  • #226 0fdf371 Thanks @remcohaszing! - Add experimental IntelliSense

    To enable IntelliSense, set mdx.experimentalLanguageServer to true in your
    VSCode settings.
    You can verify it’s enabled by interacting with the JavaScript parts on an MDX
    document, for example by hovering an import or variable

  • #222 d2eb7a7 Thanks @KeyboardSounds! - Support for highlighting JSX evaluated expressions

    In JSX, you can include JS expressions within tags, like:

    <Component>{doSomething('a', 7)}</Component>

    This PR adds syntax highlighting for those expressions by adding a new pattern
    in the tmLanguage.json.

@github-actions github-actions bot force-pushed the changeset-release/main branch 2 times, most recently from 2df3da7 to b992cd3 Compare January 13, 2023 13:42
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s get this merged!

I guess this will automagically create a release? We’ll see.

@remcohaszing remcohaszing merged commit 67042ba into main Jan 13, 2023
@remcohaszing remcohaszing deleted the changeset-release/main branch January 13, 2023 14:11
@wooorm
Copy link
Member

wooorm commented Jan 13, 2023

Would be good to create a GH release as well (https://github.com/mdx-js/vscode-mdx/releases)

@remcohaszing
Copy link
Member

I think it should, based on tags, but no tag is created.

@remcohaszing
Copy link
Member

I’ll create a tag manually.

@remcohaszing
Copy link
Member

Ok, so there are some quirks to resolve:

  • Changesets creates a release PR
  • A tag should be created (created manually)
  • A tag should create a release (created manually)
  • A release should
    • Package the extension
    • Publish to VSCode marketplace
    • Publish to OpenVSX
    • Attach built package to release

So it is published now, but it needs some streamlining. Also packages need to be published eventually.

@remcohaszing
Copy link
Member

https://twitter.com/remcohaszing/status/1613910319805382657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants