Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fleet missions' code | Part 12 | Combat morale updates #110

Merged
merged 10 commits into from
Apr 19, 2020

Conversation

mdziekon
Copy link
Owner

Summary:

All three possible combat missions (MissionAttack, MissionDestruction & MissionGroupAttack) share almost the same mechanism of combat morale updating. This mechanism should be implemented in just one place and shared among them.

Changelog:

  • Export combat morale updating into a separate function
    • Function export (as utility)
    • Use in Regular attack
    • Use in Group attack (ACS)
    • Use in Moon destruction
  • Fix United Attacks morale updater, where in cases of significant "stronger" attackers group, the defender would get a morale boost even when the attackers won the battle (defenders should get a boost only when they won or they drawn the battle)
  • Unify loading data from morale cache into a variable

Related issues or PRs:

@mdziekon mdziekon added pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals labels Apr 19, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Apr 19, 2020
@mdziekon mdziekon merged commit 41b05d2 into master Apr 19, 2020
Basic modernisation automation moved this from In progress to Done Apr 19, 2020
@mdziekon mdziekon deleted the mdziekon/91/fleet-mission-attack-refactor-part12 branch April 19, 2020 20:36
@mdziekon mdziekon added this to In progress in Flight Control refactor via automation Apr 8, 2022
@mdziekon mdziekon removed this from Done in Basic modernisation Apr 8, 2022
@mdziekon mdziekon moved this from In progress to Done in Flight Control refactor Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant