Refactor fleet missions' code | Part 14 | Moon creation refactor

[mdziekon]

Summary:

All three possible combat missions (MissionAttack, MissionDestruction & MissionGroupAttack) share almost the same mechanism of moon creation and statistics update related to that event. This mechanism should be implemented in just one place and shared among them.

Changelog:

• Move moon creation roll (calculating whether the moon has been created or not based on random roll) to a helper function
• Simplify moon creation code in all attack missions
• Fix a bug in regular & destruction attacks, where with moon creation chance below the max. 20%, the percentages would not be recorded towards one of the Tasks (key BATTLE_WINORDRAW_SOLO_TOTALLIMIT)
• CreateOneMoonRecord.php has been refactored to simplify its branching
• Admin's Add Moon page has been refactored in its rendering and command handling code

Notes:

• A minor bug has been found in the destruction mission, where even though a moon has a chance to be created again after a successful destruction, it's not being created. The cause is pretty simple - the moon creator function (CreateOneMoonRecord) is not aware that it should skip the "moon existence" check, because the destruction was not yet applied to the DB.

Related issues or PRs:

• Refactor fleet missions' code #91