Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable expeditions (basic functionality) #123

Merged
merged 27 commits into from
Aug 1, 2020
Merged

Re-enable expeditions (basic functionality) #123

merged 27 commits into from
Aug 1, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Aug 1, 2020 •
edited
Loading

Summary:

The old expeditions code needed a complete rewrite due to its incompatibility with "new" Flights handling systems. For now, it only implements two events: nothing happened and resources found. More events should be added in future Pull Requests.

Changelog:

  • Complete rewrite of the expeditions code.
  • Expeditions (as a mission) has been re-enabled by default.
  • Added feature flags capability, allowing to disable expeditions by changing .FEATURES__EXPEDITIONS__ISENABLED constant's value from true to false.
  • Fixed expedition shortcut in Galaxy view to always point to the currently selected galaxy & solar system's coords
    • Previously, it would stay at the "initial" coordinates
  • Fleet destruction reason codes are easier to use in code now (unique Enum)

Is migration required?

YES

Related issues or PRs:

@mdziekon
GH-90 Fix UserDevScanner's statistics building code
ecc6395
@mdziekon
GH-90 Create basic fleet handling code for the new expeditions system
27f27d8
@mdziekon
GH-90 Fix dev dump creation when iterating over element categories & …
d8d9925 
…simplify it
@mdziekon
GH-90 Create basic randomizers for expeditions
de44aba
@mdziekon
GH-90 Minor documentation spelling mistake spotted, might as well fix it
6b5c8ed
@mdziekon
GH-90 Add fleet update-related code to the new expedition system
47129e3 
(fleet row updates, development log insertion & fleet archive insertion)
@mdziekon
GH-90 Create FleetDestructionReason enum
d66acd9
@mdziekon
GH-90 Replace all fleet destruction codes with enum values
dfa13e4
@mdziekon
GH-90 Remove comment from fleet_archive::Fleet_Destroyed_Reason and p…
159e63f 
…rovide migration for that
@mdziekon
GH-90 Remove last hardcoded pieces of destruction reason codes
6cbd6e5
@mdziekon
GH-90 Add basic expedition messages
5c4afe5
@mdziekon
GH-90 Prepare expedition events message creators & their respective m…
a970c0a 
…essages
@mdziekon
GH-90 Send expedition result message to the user
cf75533
@mdziekon
GH-90 Unify messages sending
22fb997
@mdziekon
GH-90 Fix expedition handler's ID in UserDevScanner
984305d
@mdziekon
GH-90 Gather expeditions count statistics for users
2c09271
@mdziekon
GH-90 Remove the old code of expeditions completely
8d9bf25
@mdziekon
GH-90 Include the correct, new code of expeditions
23d7d98
@mdziekon
GH-90 Re-enable expeditions
e000ba9
@mdziekon
GH-90 Add a shortcut in Galaxy view to send an expedition
d7ffcbb
@mdziekon
GH-90 Properly handle expedition coords with auto-fill
4f09fdb
@mdziekon
GH-90 Add ability to check whether certain feature is enabled
6c5f614
@mdziekon
GH-90 Allow to disable expeditions using feature flags
40c21b7
@mdziekon
GH-90 Remove unused footer row & replace expedition label
ee75325
@mdziekon
GH-90 Add FEATURES__EXPEDITIONS__ISENABLED const to the installation …
93c1156 
…script
@mdziekon
GH-90 Add migration which adds the FEATURES__EXPEDITIONS__ISENABLED c…
5dce283 
…onst
@mdziekon mdziekon added pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals labels Aug 1, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Aug 1, 2020
@mdziekon mdziekon merged commit cbd64cf into master Aug 1, 2020
Basic modernisation automation moved this from In progress to Done Aug 1, 2020
This was referenced Aug 1, 2020
Open
Open
@mdziekon mdziekon deleted the mdziekon/90/refactor-expeditions-part01 branch August 1, 2020 19:53
@mdziekon mdziekon mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals
Projects
Basic modernisation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reinstate expedition fleet mission's code
1 participant
@mdziekon