Refactor fleet missions' code | Part 20 | Target info getter refactor #189

mdziekon · 2022-04-07T00:20:21Z

Summary:

...

Move target details getting (galaxy / planet info, owning user info, state flags) into an encapsulated util
Move planet details out of owning user's details to separate concerns

mdziekon added 4 commits April 7, 2022 01:11

GH-91 Create new targetInfo getter

2ba20bc

GH-91 Start using new targetInfo getter

3c23854

GH-91 Start migrating away from merged user & planet props

8bf6dde

GH-91 Remove compatibility layer on galaxy_id

e6def8f

mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Apr 7, 2022

mdziekon added this to In progress in Basic modernisation via automation Apr 7, 2022

mdziekon added 8 commits April 8, 2022 01:53

GH-91 Use migration paths in pre-flight summary view as well

ea8afee

GH-91 Allow to enable & disable extended details fetching

d30b7f1

GH-91 Migrate fleet2 to use getTargetInfo as well

deb9024

GH-91 Get rid of array() code style

bcd368e

GH-91 When there's no result, don't try to attach more data

dc5054d

GH-91 Get rid of the migration layer

ca37a7b

GH-91 Remove unnecessary whitespace

e4f297e

GH-91 Simplify the code a bit

03e9a3b

mdziekon mentioned this pull request Apr 8, 2022

Refactor fleet missions' code #91

Open

mdziekon marked this pull request as ready for review April 8, 2022 00:50

mdziekon merged commit 8b80afe into master Apr 8, 2022

Basic modernisation automation moved this from In progress to Done Apr 8, 2022

mdziekon added this to In progress in Flight Control refactor via automation Apr 8, 2022

mdziekon removed this from Done in Basic modernisation Apr 8, 2022

mdziekon moved this from In progress to Done in Flight Control refactor Apr 8, 2022

mdziekon deleted the gh-91-assorted-improvements-01 branch April 8, 2022 01:00