Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port minor fixes to the codebase from PR #61 | Part 2 #65

Merged
merged 9 commits into from
Jan 19, 2020
Merged

Port minor fixes to the codebase from PR #61 | Part 2 #65

merged 9 commits into from
Jan 19, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Jan 19, 2020 •
edited

Part of #63

Changelog:

  • Namespace user-related helpers
  • Time-related helpers moved to their own file
  • Add helpers related to world's resources (keys getters and checks)
  • Add helpers related to world's elements (type checkers, state getters)
  • Add helpers related to calculating elements' upgrade / purchase price
  • IsElementBuyable has been simplified and reuses new helpers

@mdziekon mdziekon mentioned this pull request Jan 19, 2020
Closed
@mdziekon mdziekon merged commit 420820f into master Jan 19, 2020
@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Jan 19, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Jan 19, 2020
@mdziekon mdziekon deleted the mdziekon/63/port-minor-modifications-part2 branch January 22, 2020 21:01
@mdziekon mdziekon moved this from In progress to Done in Basic modernisation Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Basic modernisation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdziekon