Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port minor fixes to the codebase from PR #61 | Part 13 #77

Merged
merged 20 commits into from
Feb 28, 2020
Merged

Port minor fixes to the codebase from PR #61 | Part 13 #77

merged 20 commits into from
Feb 28, 2020

Conversation

mdziekon
Copy link
Owner

Part of #63

Changelog:

  • General code cleaup in Research grid page

@mdziekon
GH-63 Simplify length queue checking
4a847f5
@mdziekon
GH-63 Refactor tech requirements checking
079e66b
@mdziekon
GH-63 Refactor max level checking
021b63f
@mdziekon
GH-63 Slightly refactor level modifier label creation
cb487a1
@mdziekon
GH-63 Refactor upgrade resources checking
00aa233
@mdziekon
GH-63 Refactor vacation check
cb2cea0
@mdziekon
GH-63 Remove redundant variable
6442e2f
@mdziekon
GH-63 Simplify checking research planet a bit
c6a91de
@mdziekon
GH-63 Simplify research lab existence checking
2a328c9
@mdziekon
GH-63 Refactor getting the queued level of element
fba60ce
@mdziekon
GH-63 Simplify current level handling
c0920e0
@mdziekon
GH-63 Improve checks reusability when determining upgradeability
4aa55dd
@mdziekon
GH-63 Move lab & queue checks out of the loop
bab079a
@mdziekon
GH-63 Simplify hiding the quick upgrade button
c998318
@mdziekon
GH-63 Simplify how the final quick upgrade button's color is determined
9fca1ae
@mdziekon
GH-63 Make "disabled state" determination logic more reasonable
d8a18c4
@mdziekon
GH-63 Remove old quick upgrade button color picking code
67c0fb8
@mdziekon
GH-63 Fix color matching & simplify more logic related to quick butto…
c2e44c8 
…n's state
@mdziekon
GH-63 Remove unused globals
a34882c
@mdziekon
GH-63 Minor code cleanups
95bcebe
@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Feb 28, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Feb 28, 2020
@mdziekon mdziekon mentioned this pull request Feb 28, 2020
Closed
@mdziekon mdziekon marked this pull request as ready for review February 28, 2020 17:10
@mdziekon mdziekon merged commit db958be into master Feb 28, 2020
Basic modernisation automation moved this from In progress to Done Feb 28, 2020
@mdziekon mdziekon deleted the mdziekon/63/port-minor-modifications-part13 branch March 3, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Basic modernisation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdziekon