Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port minor fixes to the codebase from PR #61 | Part 17 #83

Merged
merged 19 commits into from
Mar 8, 2020
Merged

Port minor fixes to the codebase from PR #61 | Part 17 #83

merged 19 commits into from
Mar 8, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Mar 8, 2020 •
edited

Part of #63

Changelog:

  • Move code responsible for gathering destruction details into a separate function
  • Refactor element icon grouping code
  • Overall code refactor & unification

@mdziekon
GH-63 Move destruction tooltip details generation to a util function
e351723
@mdziekon
GH-63 Create groupBy utility
3bd890f
@mdziekon
GH-63 Create groupInRows utility
59e7a77
@mdziekon
GH-63 Simplify grouping logic in Structures page code
2cfeb67
@mdziekon
GH-63 Further code cleanups of Structures page code
c987f69
@mdziekon
GH-63 Create Elements\isProductionRelated() helper
5db078b
@mdziekon
GH-63 Don't manually check if an element is production related
63b4992
@mdziekon
GH-63 Further cleanups
d2f32d5
@mdziekon
GH-63 Rename page template data var
ed0686d
@mdziekon
GH-63 Minor code style fixes
9ba8f8f
@mdziekon
GH-63 Simplify grouping logic in Laboratory page code
8893f35
@mdziekon
GH-63 Further cleanups of Laboratory page code
61578af
@mdziekon
GH-63 Use element state getter instead of manual access to the lab's …
8ab7add 
…level
@mdziekon
GH-63 Minor code style cleanups
6d1436d
@mdziekon
GH-63 Var renames
93df2c9
@mdziekon
GH-63 Simplify how it is determined whether research is in progress
0d58e1c
@mdziekon
GH-63 Don't count tech queue's length manually and unify some code
ff9c69a
@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Mar 8, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Mar 8, 2020
@mdziekon mdziekon marked this pull request as ready for review March 8, 2020 10:50
@mdziekon mdziekon merged commit 1606d21 into master Mar 8, 2020
Basic modernisation automation moved this from In progress to Done Mar 8, 2020
@mdziekon mdziekon mentioned this pull request Mar 8, 2020
Closed
@mdziekon mdziekon changed the title Port minor fixes to the codebase from PR #61 | Part 16 Port minor fixes to the codebase from PR #61 | Part 17 Mar 8, 2020
@mdziekon mdziekon deleted the mdziekon/63/port-minor-modifications-part17 branch March 8, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Basic modernisation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdziekon