-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor fleet missions' code | Part 01 | Resources pillaging calculation #92
Merged
mdziekon
merged 17 commits into
master
from
mdziekon/91/fleet-mission-attack-refactor-part01
Mar 28, 2020
Merged
Refactor fleet missions' code | Part 01 | Resources pillaging calculation #92
mdziekon
merged 17 commits into
master
from
mdziekon/91/fleet-mission-attack-refactor-part01
Mar 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdziekon
added
the
pr:enhancement_request
All pull requests related to enhancements proposals
label
Mar 25, 2020
mdziekon
force-pushed
the
mdziekon/91/fleet-mission-attack-refactor-part01
branch
from
March 25, 2020 21:39
383cc1d
to
49c0446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr:bugfix
All pull requests related to fixing bugs
pr:enhancement_request
All pull requests related to enhancements proposals
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently there are three places with resources pillaging code duplicated. All of them should use a shared function to calculate how much resources should be pillaged from a raided planet / moon.
Changelog:
Related issues or PRs: