Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fleet missions' code | Part 02 | Resources loss & debris calculation #93

Merged
merged 6 commits into from
Mar 29, 2020
Merged

Refactor fleet missions' code | Part 02 | Resources loss & debris calculation #93

merged 6 commits into from
Mar 29, 2020

Conversation

mdziekon
Copy link
Owner

Summary:

Currently there are three places with resources loss and debris calculation code duplicated. All of them should use a shared function to calculate these values.

Changelog:

  • Extract resources loss & debris calculating function into its separate file
    • Rewrite it into something easier to understand
    • Write tests
  • Use the new calculation function in attacks handling functions:
    • Regular attack
    • Group attack (ACS)
    • Moon destruction

Related issues or PRs:

@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Mar 29, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Mar 29, 2020
@mdziekon mdziekon merged commit a329672 into master Mar 29, 2020
Basic modernisation automation moved this from In progress to Done Mar 29, 2020
@mdziekon mdziekon mentioned this pull request Mar 29, 2020
Open
@mdziekon mdziekon linked an issue Mar 29, 2020 that may be closed by this pull request
Refactor fleet missions' code #91
Open
@mdziekon mdziekon removed a link to an issue Mar 29, 2020
Refactor fleet missions' code #91
Open
@mdziekon mdziekon deleted the mdziekon/91/fleet-mission-attack-refactor-part02 branch March 29, 2020 23:15
@mdziekon mdziekon removed this from Done in Basic modernisation Apr 8, 2022
@mdziekon mdziekon added this to In progress in Flight Control refactor via automation Apr 8, 2022
@mdziekon mdziekon moved this from In progress to Done in Flight Control refactor Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Flight Control refactor
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdziekon