Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fleet missions' code | Part 05 | User technologies initialization #96

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Apr 2, 2020

Summary:

Currently there are several places where user technologies are prepared for combat calculation. All of that duplication should be merged into one shared utility.

Changelog:

  • Extract user technologies initialization function
  • Use the new tech initialization functions in attacks handling functions:
    • Regular attack
    • Group attack (ACS)
    • Moon destruction

Related issues or PRs:

@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Apr 2, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Apr 2, 2020
@mdziekon mdziekon changed the title Refactor fleet missions' code | Part 06 | Morale modifiers calculation Refactor fleet missions' code | Part 06 | User technologies initialization Apr 2, 2020
@mdziekon mdziekon changed the title Refactor fleet missions' code | Part 06 | User technologies initialization Refactor fleet missions' code | Part 05 | User technologies initialization Apr 2, 2020
@mdziekon mdziekon merged commit f7e8912 into master Apr 2, 2020
Basic modernisation automation moved this from In progress to Done Apr 2, 2020
@mdziekon mdziekon deleted the mdziekon/91/fleet-mission-attack-refactor-part05 branch April 2, 2020 22:04
@mdziekon mdziekon removed this from Done in Basic modernisation Apr 8, 2022
@mdziekon mdziekon added this to In progress in Flight Control refactor via automation Apr 8, 2022
@mdziekon mdziekon moved this from In progress to Done in Flight Control refactor Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant