Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fleet missions' code | Part 07 | Post-combat fleet updates #98

Merged
merged 19 commits into from
Apr 7, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Apr 5, 2020

Summary:

Certain actions like pillage storage capacity calculation, fleet row updates aggregation & development log updates aggregation are all common to all three types of attacks (Solo, United, Destruction), however they all have these actions duplicated in the code. These things should all be shared, one way or the other.

Changelog:

  • Export pillage storage capacity calculation into a separate function
    • Function export (as utility)
    • Use in Regular attack
    • Use in Group attack (ACS)
    • Use in Moon destruction
  • Export fleet update entries aggregation into a separate util function
    • Function export (as utility)
    • Use in Regular attack
    • Use in Group attack (ACS)
    • Use in Moon destruction
  • Export fleet change devlog entries aggregation into a separate util function
    • Function export (as utility)
    • Update the utility to handle pillages resources as well
    • Use in Regular attack
    • Use in Group attack (ACS)
    • Use in Moon destruction

Related issues or PRs:

@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Apr 5, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Apr 5, 2020
@mdziekon mdziekon changed the title Refactor fleet missions' code | Part 06 | Post-combat fleet updates Refactor fleet missions' code | Part 07 | Post-combat fleet updates Apr 5, 2020
@mdziekon mdziekon marked this pull request as ready for review April 7, 2020 22:34
@mdziekon mdziekon merged commit 96130dc into master Apr 7, 2020
Basic modernisation automation moved this from In progress to Done Apr 7, 2020
@mdziekon mdziekon deleted the mdziekon/91/fleet-mission-attack-refactor-part07 branch April 7, 2020 22:42
@mdziekon mdziekon removed this from Done in Basic modernisation Apr 8, 2022
@mdziekon mdziekon added this to In progress in Flight Control refactor via automation Apr 8, 2022
@mdziekon mdziekon moved this from In progress to Done in Flight Control refactor Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant