Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling book section on mdzk.toml #41

Merged
merged 2 commits into from Nov 6, 2021
Merged

handling book section on mdzk.toml #41

merged 2 commits into from Nov 6, 2021

Conversation

ratsclub
Copy link
Member

@ratsclub ratsclub commented Nov 6, 2021

Motivation

When migrating from mdBook, one needs to update the book.toml to mdzk.toml and sometimes people forget to change the [book] section to [mdzk].

Linked Issues/PRs/Discussions

#40

@ratsclub
Copy link
Member Author

ratsclub commented Nov 6, 2021

Panicking is ugly but I couldn't find a way to make this error go all the up to the main function. May you help me with this?

src/config.rs Outdated Show resolved Hide resolved
@kmaasrud
Copy link
Member

kmaasrud commented Nov 6, 2021

Additionally, config.rs:33 has an unwrap that can be replaced with a ? for a graceful and more informative message. Adding some context would be helpful as well, I can do that now

@kmaasrud kmaasrud merged commit f5a2e4a into main Nov 6, 2021
@kmaasrud kmaasrud deleted the pr-40 branch November 6, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants