for service restart #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenEng
commented
Jan 19, 2018
| for (const containerInfo of containers) { | ||
| //console.log(JSON.stringify(containerInfo)); | ||
| for (var net_name in containerInfo.NetworkSettings.Networks) { | ||
| let service_name = name.replace("-core-store", "").replace("-store-json", ""); |
There was a problem hiding this comment.
is restarting stores not a good idea now?
This line is basically to guarantee that restarting a store could work too, at least at the level of core-network
but seems to have some key/token issues involved after a new store comes to life
There was a problem hiding this comment.
I've got lines of
CURVE I: cannot open client HELLO -- wrong server key?
from new store's output
sevenEng
referenced
this pull request
in me-box/core-network
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue me-box/databox#230
together with core-network#restart-app
before killing the container, get it's IP as
old_ipafter the restart, get the
new_ip, if different, call on core-network to do the substitutionseems to still have some timing issue in this solution, as the container's new IP is available, but before states within core-network is updated, traffic will not be able to get through
tested by restarting both app and driver (for os-monitor)