Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzipped file only serverd if uncompressed file exists, too #4

Closed
andig opened this issue Jan 23, 2016 · 4 comments
Closed

gzipped file only serverd if uncompressed file exists, too #4

andig opened this issue Jan 23, 2016 · 4 comments

Comments

@andig
Copy link
Contributor

andig commented Jan 23, 2016

Problem is that .gz existence is checked in two places. See https://github.com/me-no-dev/ESPAsyncWebServer/blob/master/src/AsyncWebServerHandlerImpl.h#L24

Needs change similar to this or better:

  _isFile = _fs.exists(path) || _fs.exists((String(path)+".gz").c_str());
@me-no-dev
Copy link
Owner

done! and thanks :) 3c658dc

@andig
Copy link
Contributor Author

andig commented Jan 23, 2016

I have to thank you. The async server is from another dimension ;)

On Sat, Jan 23, 2016 at 6:07 PM, Me No Dev notifications@github.com wrote:

done! and thanks :) 3c658dc
3c658dc


Reply to this email directly or view it on GitHub
#4 (comment)
.

@andig
Copy link
Contributor Author

andig commented Jan 23, 2016

:)

@andig andig closed this as completed Jan 23, 2016
@me-no-dev
Copy link
Owner

I have been dreaming about it for a while :) it took some time to take on the task to parse partially received data and to send stuff in chunks :0 today I stumbled upon chunked output which can help much in streaming unknown length content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants