-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompiling some SFXGame classes breaks the game (LE1/LE3) #396
Comments
…. Locals should not have any flags, and parms should only have parm flags. Part of #396 Optimized getting the binary offset in export data.
Thanks for the detailed report! I've fixed the first issue; BioSeqAct_BioToggleCinematicMode should recompile identically now. |
Can confirm that issue 1 is fixed. UPD: SFXGameModeBase (LE3) also breaks upon recompilation because some of its functions changed exports, not sure which exactly. The game just won't load into the menu. |
Decompiling and recompiling some vanilla classes from SFXGame.pcc (even without any changes) produces unexpected behaviour in LE1.
Verbose description for two problematic classes I've encountered:
BioSeqAct_BioToggleCinematicMode (LE1)
![comp1](https://private-user-images.githubusercontent.com/75280223/265548170-ff9dabb0-5679-434e-a482-9af0ca3449bf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTg1ODMsIm5iZiI6MTcyMTUxODI4MywicGF0aCI6Ii83NTI4MDIyMy8yNjU1NDgxNzAtZmY5ZGFiYjAtNTY3OS00MzRlLWE0ODItOWFmMGNhMzQ0OWJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIzMzEyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJkNWQ4OTc2ZGFmZWFiMGI1OTM4ZTY0NDczMDdkNGFkODNjZWRhM2YwNWQzYWQ0NzM3ODEwYjAwMDMxNzc4MmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XGEiHqjTtV6mUCL5hhromB86yQKoKztb4Jp6EfzWYFM)
The game stops responding if you drive into the Geth Armature cutscene on Noveria Mako section. Interestingly, it doesn't crash if you start the cutscene on foot.
Removing the call to
oBehavior.AbilityEnable(FALSE, 0, 'All');
or wrapping it withif player not in vehicle
check mitigates the issue.To reproduce, take vanilla SFXGame.pcc, open this class in Package Editor, click Compile and save, then enter the Geth Armature cutscene while driving Mako.
Comparison vanilla<->recompiled:
SFXGameModeConversation (LE1)
![2comp](https://private-user-images.githubusercontent.com/75280223/265548122-a8f86177-f537-4ce6-8f3c-29516d851f42.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTg1ODMsIm5iZiI6MTcyMTUxODI4MywicGF0aCI6Ii83NTI4MDIyMy8yNjU1NDgxMjItYThmODYxNzctZjUzNy00Y2U2LThmM2MtMjk1MTZkODUxZjQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIzMzEyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhNzZhMGZlYTQ2OTUxNjk5ZTUxY2Y4MjAzYmI1NDllNjg5MTliMmU1ZTk0ZGVkYWQxYjA1N2Q2YWQ3OWQxOTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eHw3Pq4Io94ZsEcmP5DWTxeKeSHkPz7d9RGmjKFxvhI)
Issue: The game softlocks after loading any savegame if you load it after finishing Benezia fight on Noveria. While softlocked, the camera is fixed somewere out of bounds, and the player character is marked as dead ("Cannot save while dead" text in menu). Also, you have to click the buttons twice whilst in menu - the first time to gain focus, the second time to actually click.
To reproduce, recompile, then kill Benezia and reload after her last words ("No light?..").
Comparison vanilla<->recompiled:
Version information:
Stable 6.3.0.5422
Nightly 6.3.0.5473
The text was updated successfully, but these errors were encountered: