Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string_selectModArchive and related #18

Closed
HarHarLinks opened this issue Dec 1, 2019 · 2 comments
Closed

string_selectModArchive and related #18

HarHarLinks opened this issue Dec 1, 2019 · 2 comments

Comments

@HarHarLinks
Copy link
Contributor

ME3TweaksModManager/MassEffectModManagerCore/modmanager/localizations/int.xaml

Line 173 in 50d3327

<system:String x:Key="string_selectModArchive">Select mod archive</system:String>

In many cases it is clear by context that archive means a .7z/.rar/.zip file. In this and some other cases, I fear it might not be.
@Mgamerz
Copy link
Member

Mgamerz commented Dec 1, 2019 •
edited
Loading

Many of these strings are context sensitive. For example this string is used as the title of a file picking window. Some others are used as tooltips, which explain some items in further detail.

@Mgamerz
Copy link
Member

Mgamerz commented Dec 12, 2019

This string is only used as the title of a file picker dialog that shows up after you specifically choose the menu item to import 7z/rar/zip.

image

As such, this is the correct use of the string.

@Mgamerz Mgamerz closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mgamerz @HarHarLinks