-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function collections #156
Function collections #156
Conversation
lagom/interfaces.py
Outdated
@@ -198,4 +198,5 @@ def reflection_cache_overview(self) -> Dict[str, str]: | |||
SpecialDepDefinition[T], # From the definitions module | |||
SpecialDepDefinition[NoReturn], # Some types don't resolve | |||
T, # Just an instance of the type - A singleton | |||
List[Callable], # A collection of functions - maps to FunctionCollection[F] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I don't need this "magic" at all 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I don't like this magic. I think I'll remove this and just provide FunctionCollection as a helper
""" | ||
|
||
def __init__(self, *checkers: F): | ||
self._checkers = checkers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename it from checkers. This was from my project that I extracted it from
42bfd2e
to
677c07d
Compare
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 1.10%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
No description provided.