Add dependency stack when formatting UnresolvableType #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bastienexertier this looks really useful 👍 There's an error when running against the compiled version of the code. I'm a bit pushed for time today but I should be able to take a look later and offer some suggestions. |
|
Sounds good! |
|
Since the only test was some of the message missing when running on the compiled code I've just skipped the test for now. It can always be worked on in the future to improve it. This looks great 👍 so I'll merge it and release it soon. Thanks @bastienexertier for spending the time on this. |
|
Released as 2.4.0 https://github.com/meadsteve/lagom/releases/tag/2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help users identify which dependency is unresolvable when a UnresolvableType error is thrown.